ci: add strict-no-cover to detect unnecessary coverage pragmas #1897
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxisbey
force-pushed
the
add-strict-no-cover
branch
from
6f96e17 to
78d6633
Compare
Add strict-no-cover from pydantic to CI pipeline. This tool identifies `# pragma: no cover` comments on lines that are actually covered by tests, helping keep coverage pragmas accurate. Changes: - Add strict-no-cover as dev dependency (installed from git) - Add `pragma: lax no cover` to coverage exclude_lines for partial coverage - Add CI step to run strict-no-cover after coverage report (Linux only due to Windows bug in the tool)
maxisbey
force-pushed
the
add-strict-no-cover
branch
from
78d6633 to
edefce3
Compare
maxisbey
commented
Jan 17, 2026
| uv run --frozen --no-sync coverage report | ||
| - name: Check for unnecessary no cover pragmas | ||
| if: runner.os != 'Windows' |
Contributor
Author
There was a problem hiding this comment.
@Kludex without this all the windows pipelines fail to even run, seems like a strict-no-cover bug? Example failure from previous CI run: https://github.com/modelcontextprotocol/python-sdk/actions/runs/21070443439/job/60598385217
Member
|
Is this working already? All the pragmas are actually being used? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add strict-no-cover from pydantic to the CI pipeline. This tool identifies
# pragma: no covercomments on lines that are actually covered by tests, helping keep coverage pragmas accurate.Changes
pragma: lax no coverto coverage exclude_lines for partial coverage scenariosHow it works
# pragma: no cover- errors if any marked lines are actually covered# pragma: lax no cover- permits partial coverage without erroring (useful for flaky or inconsistently covered code)